feat(weave_query): add ability to view traces on query panels #3147
+450
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚧 This is WIP 🚧
Internal doc
This draft (as of PR creation) contains two ops and an api client to handle loading weave traces onto query panels.
project.traces({})
project.traces({filter: {trace_roots_only: true}, limit: 10000, offset: 0, sort_by: [{field: "started_at", direction: "desc"}]})
@nicholaspun-wandb , there are minor tweaks to be made like adding feedback and cost support, but I think some interesting meaty items to take on could be:
Development Notes / Tips
I spent too much time toiling over the ops not matching only to realize that my changes to
weave-public
weren't being reflected in the dev environment.Make sure you:
weave-python
andpip install -e ./weave-public/weave_query/
weave_server.wandb
thru governor. I found that I needed to do this to propagate code changes and flush any stdout I debug printed.core
then switch back, make sure you redo step 1 from above.app.wandb
's HMR. I found that this takes way too long due to import cycles (depending on the file you updated). Sometimes it's faster to [s]top and [r]eload it on governor.What does the PR do? Include a concise description of the PR contents.
tbd
Testing
tbd