Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weave_query): add ability to view traces on query panels #3147

Closed
wants to merge 7 commits into from

Conversation

domphan-wandb
Copy link
Contributor

Description

🚧 This is WIP 🚧

Internal doc

This draft (as of PR creation) contains two ops and an api client to handle loading weave traces onto query panels.

  • The query panel can be tested by using the expression project.traces({})
    • Another example with currently implemented payload fields: project.traces({filter: {trace_roots_only: true}, limit: 10000, offset: 0, sort_by: [{field: "started_at", direction: "desc"}]})

@nicholaspun-wandb , there are minor tweaks to be made like adding feedback and cost support, but I think some interesting meaty items to take on could be:

  1. A spike on figuring out a more efficient way to get the column types of the calls
  2. Adding feature flagging support to limit access to this op

Development Notes / Tips

I spent too much time toiling over the ops not matching only to realize that my changes to weave-public weren't being reflected in the dev environment.

Make sure you:

  1. navigate to weave-python and pip install -e ./weave-public/weave_query/
  2. every time you make a change to weave_query (python), [s]top and [r]eload weave_server.wandb thru governor. I found that I needed to do this to propagate code changes and flush any stdout I debug printed.
  3. if you switch branches on core then switch back, make sure you redo step 1 from above.
  4. Don't always wait for app.wandb's HMR. I found that this takes way too long due to import cycles (depending on the file you updated). Sometimes it's faster to [s]top and [r]eload it on governor.
image
  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do? Include a concise description of the PR contents.

tbd

Testing

tbd

@circle-job-mirror
Copy link

circle-job-mirror bot commented Dec 4, 2024

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant